Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing the prompt view cancel button style for color and cursor … #34209

Conversation

bogdan3d
Copy link
Contributor

@bogdan3d bogdan3d commented Feb 8, 2024

Description

This is a backport of #33895 to quince.

Supporting information

Fixes openedx/wg-build-test-release#322 in quince.

Testing instructions

Follow steps in #33895 except first step will be to install the quince release using tutor instead of the nightly release. This can be done by executing the following:

pip install "tutor[full]==17.0.0"

...instead of...

pip install -e "./tutor[full]"

Deadline

N/A

Other information

This is a screenshot showing that the issue was reproduced in quince:
reproducing_in_quince

This is a screenshot after the fix was applied to quince:
fixing_in_quince

@openedx-webhooks
Copy link

Thanks for the pull request, @bogdan3d! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 8, 2024
@bogdan3d bogdan3d force-pushed the quince-backport-fix-prompt-view-cancel-button-style-for-color-and-cursor-shape branch from a37312f to 766d3b6 Compare February 8, 2024 03:55
@bogdan3d bogdan3d force-pushed the quince-backport-fix-prompt-view-cancel-button-style-for-color-and-cursor-shape branch from 766d3b6 to a0c97d6 Compare February 8, 2024 03:59
@cmltaWt0
Copy link
Contributor

cmltaWt0 commented Feb 8, 2024

Tested on Quince - works as expected. Thanks!

@cmltaWt0 cmltaWt0 merged commit ac68aae into openedx:open-release/quince.master Feb 8, 2024
43 checks passed
@openedx-webhooks
Copy link

@bogdan3d 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants